feat(nav-bar-functionality): Store expanded nav state in AssessmentStore and toggle nav link expansion state #2768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haonliu
previously approved these changes
May 28, 2020
pownkel
changed the title
waabid
reviewed
May 28, 2020
waabid
reviewed
May 28, 2020
| @@ -70,6 +70,7 @@ export interface TestStepResult { | |||
| export interface AssessmentNavState { | |||
| selectedTestSubview: RequirementName | GettingStarted; | |||
| selectedTestType: VisualizationType; | |||
| expandedTestType?: VisualizationType; | |||
There was a problem hiding this comment.
It can be null or undefined if nothing is currently expanded
haonliu
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When the test's heading nav link is clicked, store that test as the currently expanded test in AssessmentStore and toggle the expanded state of the nav link. All links will start as collapsed by default.
Styling to highlight the expanded portion of the nav will be added in a later PR.
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.