Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nav-bar-functionality): Highlight expanded part of nav #2778

Merged
merged 1 commit into from
Jun 2, 2020
Merged

feat(nav-bar-functionality): Highlight expanded part of nav #2778

merged 1 commit into from
Jun 2, 2020

Conversation

pownkel
Copy link
Contributor

@pownkel pownkel commented Jun 1, 2020

Description of changes

Add styling to highlight the expanded part of the nav to match the figma:

expanded nav highlighting expanded nav highlighting high contrast

Pull request checklist

  • Addresses an existing issue: #1724870
  • Ran yarn fastpass
  • [n/a] Added/updated relevant unit test(s) (and ran yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@pownkel pownkel requested a review from a team as a code owner June 1, 2020 22:19
waabid
waabid approved these changes Jun 1, 2020
View reviewed changes
Copy link
Member

@waabid waabid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any chance we could use this via css-modules?

@haonliu
Copy link
Contributor

haonliu commented Jun 1, 2020

LGTM. Any chance we could use this via css-modules?

+1 on this

@pownkel pownkel merged commit 665cc91 into microsoft:master Jun 2, 2020
@pownkel pownkel deleted the expanded-nav-styling branch November 12, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waabid waabid waabid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pownkel @haonliu @waabid