feat(android-setup): Add detect-adb step to the state machine #2833

RobGallo · 2020-06-09T23:25:33Z

Description of changes

Add configuration for the detect-adb state machine step
Remove 'close' from AndroidSetupActions because an action to close the app exists elsewhere
Rework createAndroidSetupSteps into createStateMachineSteps so the logic could be tested independent of the types
- Remove unit tests for allAndroidSetupSteps because it is essentially a data table
- Add unit tests for createStateMachineSteps to ensure the steps in allAndroidSetupSteps will be created as expected
Add detectAdb function to AndroidSetupDeps
- if adb path is detected, the return value will be true; otherwise, false
Rename android-setup-steps-factory.ts to android-setup-steps-configs.ts
Modify StateMachineStep.onEnter to be asynchronous
- onEnter is designed to run background tasks such as detecting connected devices. Allowing such tasks to run asynchronously allows us to present UI such as wait spinners

Pull request checklist

Addresses an existing issue: #0000
Ran yarn fastpass
Added/updated relevant unit test(s) (and ran yarn test)
Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
(UI changes only) Added screenshots/GIFs to description above
(UI changes only) Verified usability with NVDA/JAWS

- Add configuration for the detect-adb state machine step - Remove 'close' from AndroidSetupActions because an action to close the app exists elsewhere - Rework createAndroidSetupSteps into createStateMachineSteps so the logic could be tested independent of the types - Remove unit tests for allAndroidSetupSteps because it is essentially a data table - Add unit tests for createStateMachineSteps to ensure the steps in allAndroidSetupSteps will be created as expected - Add detectAdb function to AndroidSetupDeps - if adb path is detected, the return value will be true; otherwise, false - Rename android-setup-steps-factory.ts to android-setup-steps-configs.ts - Modify StateMachineStep.onEnter to be asynchronous - onEnter is designed to run background tasks such as detecting connected devices. Allowing such tasks to run asynchronously allows us to present UI such as wait spinners

JGibson2019 · 2020-06-10T14:08:08Z

Should be good to go once the state machine tests are fixed!

RobGallo requested a review from a team as a code owner June 9, 2020 23:25

RobGallo closed this Jun 10, 2020