Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android-setup): add selection & device descriptions to prompt-choose-device dialog #2858

Merged
merged 5 commits into from
Jun 12, 2020
Merged

Conversation

karanbirsingh
Copy link
Contributor

@karanbirsingh karanbirsingh commented Jun 11, 2020

Description of changes

This PR adds the device-description component and selection behavior to the prompt-choose-device screen. Linking the next button's enabled/disabled behavior to the selected state required overwriting the selection model of DetailsList.

gif of dialog

suggestions appreciated on / potential upcoming PR improvements:

  • whether the Selection should be handled differently (would a separately tested and injected selection-provider make more sense?)
  • when the dialog is full screen, the max-height still affects the details list. It would be nice to avoid this
  • if the device description text is too long, text ellipses might be nice

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@karanbirsingh karanbirsingh marked this pull request as ready for review June 11, 2020 23:34
@karanbirsingh karanbirsingh requested a review from a team as a code owner June 11, 2020 23:34
@karanbirsingh karanbirsingh changed the title [draft] feat(android-setup): update prompt-choose-device dialog to have proper selection behavior feat(android-setup): update prompt-choose-device dialog to have proper selection behavior Jun 11, 2020
@karanbirsingh karanbirsingh changed the title feat(android-setup): update prompt-choose-device dialog to have proper selection behavior feat(android-setup): add selection & device descriptions to prompt-choose-device dialog Jun 11, 2020
@karanbirsingh karanbirsingh merged commit 139168c into microsoft:master Jun 12, 2020
@karanbirsingh karanbirsingh deleted the device-list branch June 12, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants