feat(android-setup): Create three state machine steps #2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGibson2019
approved these changes
Jun 12, 2020
DaveTryon
reviewed
Jun 12, 2020
| @@ -7,6 +7,6 @@ export const detectAdb: AndroidSetupStepConfig = deps => ({ | |||
| actions: {}, | |||
| onEnter: async () => { | |||
| const detected = await deps.hasAdbPath(); | |||
| deps.stepTransition(detected ? 'detect-devices' : 'prompt-locate-adb'); | |||
| deps.stepTransition(detected ? 'prompt-connect-to-device' : 'prompt-locate-adb'); | |||
There was a problem hiding this comment.
Confusion here was because it wasn't clear what hasAdbPath was doing. I read it as "is there a path in the store" when it really means "Do we have a validated ADB location?" The underlying code will decide based on whether or not the AndroidServiceConfiguratorFactory was able to return an AndroidServiceConfigurator
DaveTryon
requested changes
Jun 12, 2020
DaveTryon
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The new steps are:
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.