Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove the space at the end of nav #2871

Merged
merged 1 commit into from
Jun 12, 2020
Merged

fix: remove the space at the end of nav #2871

merged 1 commit into from
Jun 12, 2020

Conversation

haonliu
Copy link
Contributor

@haonliu haonliu commented Jun 12, 2020 •
edited
Loading

Description of changes

image

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@haonliu haonliu requested a review from a team as a code owner June 12, 2020 21:37
lisli1
lisli1 approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@lisli1 lisli1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haonliu haonliu merged commit d44929d into microsoft:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisli1 lisli1 lisli1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haonliu @lisli1