Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android-setup): Add most of the remaining state machine steps #2873

Merged
merged 7 commits into from
Jun 15, 2020
Merged

feat(android-setup): Add most of the remaining state machine steps #2873

merged 7 commits into from
Jun 15, 2020

Conversation

RobGallo
Copy link
Contributor

Description of changes

Adding

  • detect-devices
  • detect-permissions
  • detect-service
  • installing-service
  • prompt-connect-to-device
  • prompt-connected-start-testing
    -prompt-grant-permissions
  • prompt-install-service

Note: The steps 'prompt-install-service' and 'prompt-install-failed' both use the same config -- promptInstallService -- because they have the exact same behavior. The UI can still be different because the step id is different.

Note: Still need to add the config for prompt-choose-device'.

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@RobGallo RobGallo requested a review from a team as a code owner June 15, 2020 14:47
@RobGallo RobGallo merged commit dc90ccb into microsoft:master Jun 15, 2020
@RobGallo RobGallo deleted the assm branch June 15, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants