Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android-setup): add actions to prompt-choose-device-step #2876

Merged
merged 1 commit into from
Jun 15, 2020
Merged

feat(android-setup): add actions to prompt-choose-device-step #2876

merged 1 commit into from
Jun 15, 2020

Conversation

karanbirsingh
Copy link
Contributor

Description of changes

This PR links button invocations to their associated actions for the prompt-choose-device step.

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@karanbirsingh karanbirsingh requested a review from a team as a code owner June 15, 2020 20:53
JGibson2019
JGibson2019 approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@JGibson2019 JGibson2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@karanbirsingh karanbirsingh merged commit ba13670 into microsoft:master Jun 15, 2020
@karanbirsingh karanbirsingh deleted the prompt-choose-device-actions branch June 15, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JGibson2019 JGibson2019 JGibson2019 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karanbirsingh @JGibson2019