feat(android-setup): Fix adbLocation-related problems #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveTryon
commented
Jun 17, 2020
| @@ -8,7 +8,7 @@ export const promptLocateAdb: AndroidSetupStepConfig = deps => { | |||
| actions: { | |||
| saveAdbPath: (path: string) => { | |||
| deps.setAdbPath(path); | |||
| deps.stepTransition('prompt-connect-to-device'); | |||
| deps.stepTransition('detect-adb'); | |||
There was a problem hiding this comment.
The steps must successfully go through the detect-adb step before progressing to anything that needs ADB. This path was allowing us to try to prompt for devices without a validated ADB
DaveTryon
commented
Jun 17, 2020
| export const createActionMock = <Payload>( | ||
| payload: Payload, | ||
| scope: string = null, | ||
| ): IMock<Action<Payload>> => { |
There was a problem hiding this comment.
This allows us to mock the invocation with the specified scope
karanbirsingh
approved these changes
Jun 17, 2020
dbjorge
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When we put the dialogs all together, we found that things only worked if you specified adbLocation via the environment variables. This was partly because the step machine had a path that allowed execution without having a validated ADB location, and partly due to a bug in how I was passing the adbLocation through the internal layers.
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.