chore: address deprecated button warning in unified dev console #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveTryon
reviewed
Jun 17, 2020
| @@ -43,7 +43,7 @@ export const PromptConnectedStartTestingStep = NamedFC<CommonAndroidSetupStepPro | |||
| return ( | |||
| <AndroidSetupStepLayout {...layoutProps}> | |||
| <DeviceDescription {...descriptionProps}></DeviceDescription> | |||
| <Button | |||
| <DefaultButton | |||
There was a problem hiding this comment.
Is there any visual impact here?
There was a problem hiding this comment.
No, it's visually and behaviorally identical
DaveTryon
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes this warning in the dev console when hitting the prompt-connected-start-testing-step:
warn.js:13 The Button component has been deprecated. Use specific variants instead. (PrimaryButton, DefaultButton, IconButton, ActionButton, etc.)Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.