Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android-setup): set default device connect port to 62442 #2904

Merged
merged 1 commit into from
Jun 17, 2020
Merged

feat(android-setup): set default device connect port to 62442 #2904

merged 1 commit into from
Jun 17, 2020

Conversation

karanbirsingh
Copy link
Contributor

Description of changes

We currently support two parallel experiences for setting up Android devices. The first is the original 'manual-port-selection' experience in master today. The second is an in-progress automatic setup process that assumes the port 62442 for now. Our UI is shared amongst both experiences and uses the port number set in the device-store. Until we deprecate the old experience / remove the old store, we need a way to use 62442 in cases where the auto-setup feature flag is on. Out of the options:

  • update the device-store from an adb step
  • consume different ports in the UI (deviceStoreData.port referenced in >= 3 places)
  • 'update the store data' in a higher UI component when the new experience is on
  • set the default value in the store data to match

This PR uses the final approach for now.

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@karanbirsingh karanbirsingh requested a review from a team as a code owner June 17, 2020 20:11
@karanbirsingh karanbirsingh merged commit 5d97842 into microsoft:master Jun 17, 2020
@karanbirsingh karanbirsingh deleted the port branch June 17, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants