feat(android-setup): add UI for configuring-port-forwarding step #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,5 +45,6 @@ export const allAndroidSetupStepConfigs: AndroidSetupStepConfigs = { | |||
| 'prompt-install-failed': promptInstallService, | |||
| 'detect-permissions': detectPermissions, | |||
| 'prompt-grant-permissions': promptGrantPermissions, | |||
| 'configuring-port-forwarding': null, // to be implemented in future feature work | |||
There was a problem hiding this comment.
is this meant to be null?
There was a problem hiding this comment.
Yes, this is the config for the backend step; Dave will be implementing it in a separate PR
There was a problem hiding this comment.
ah, I mistook it for the UI side - thanks
karanbirsingh
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds a new loading spinner screen UI for the step where we configure port forwarding in ADB.
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.