feat(android-setup): Add code to set the app name from the device in the setup store #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveTryon
reviewed
Jun 17, 2020
src/electron/platform/android/setup/steps/detect-permissions.ts
Outdated
Show resolved
Hide resolved
DaveTryon
requested changes
Jun 17, 2020
…the setup store The app name is required for the start testing screen, and it can't be set until after the permissions have been granted. It also can't be set in the onEnter function for the start testing step because the onEnter method is asynchronous, and the UI will therefore be visible possibly before the app name is set.
…tep so that the application name is retrieved after port forwarding is successfully set up Port forwarding, not detect permissions, is when the device is set up and ready to get the app name.
DaveTryon
reviewed
Jun 19, 2020
src/tests/unit/tests/electron/platform/android/setup/live-android-setup-deps.test.ts
Outdated
Show resolved
Hide resolved
DaveTryon
reviewed
Jun 19, 2020
src/tests/unit/tests/electron/platform/android/setup/steps/detect-permissions.test.ts
Outdated
Show resolved
Hide resolved
DaveTryon
approved these changes
Jun 19, 2020
Co-authored-by: Dave Tryon <45672944+DaveTryon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The app name is required for the start testing screen, and it can't be set until after the permissions have been granted. It also can't be set in the onEnter function for the start testing step because the onEnter method is asynchronous, and the UI will therefore be visible possibly before the app name is set.
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.