Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore): Exclude .vs folder from fastpass scans #2928

Merged
merged 1 commit into from
Jun 22, 2020
Merged

(chore): Exclude .vs folder from fastpass scans #2928

merged 1 commit into from
Jun 22, 2020

Conversation

DaveTryon
Copy link
Contributor

Description of changes

I often use the branching tools in Visual Studio, but fastpass complains because it tries to scan the files in the .vs folder. This change simply excludes the .vs folder from prettier and linting checks, so that fastpass and Visual Studio can play nicely together.

Pull request checklist

  • [n/a] Addresses an existing issue: #0000
  • Ran yarn fastpass
  • [n/a] Added/updated relevant unit test(s) (and ran yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@DaveTryon DaveTryon requested a review from a team as a code owner June 20, 2020 21:42
@DaveTryon DaveTryon added the pr: auto-merge Automatically squash merge all checks have passed and approvals granted. There is a 15 minute delay. label Jun 20, 2020
@msft-github-bot
Copy link
Collaborator

Hello @DaveTryon!

Because this pull request has the pr: auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 1 minute. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msft-github-bot) and give me an instruction to get started! Learn more here.

@msft-github-bot msft-github-bot merged commit 84a9cf0 into microsoft:master Jun 22, 2020
@DaveTryon DaveTryon deleted the ExcludeVsFolderFromScans branch June 22, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: auto-merge Automatically squash merge all checks have passed and approvals granted. There is a 15 minute delay.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants