feat(android-setup): Add cancel action behavior to a few steps #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expected behavior of the cancel action for each step is as follows: step | on cancel --- | --- detect-adb | no cancel / cancel = close prompt-locate-adb | no cancel / cancel = close prompt-connect-to-device | no cancel / cancel = close detect-devices | prompt-connect-to-device prompt-choose-device | no cancel (can rescan for devices or close) detect-service | prompt-choose-device prompt-install-service | prompt-choose-device installing-service | prompt-install-service prompt-install-failed | prompt-choose-device detect-permissions | prompt-choose-device prompt-grant-permissions | prompt-choose-device configuring-port-forwarding | prompt-choose-device prompt-configuring-port-forwarding-failed | prompt-choose-device prompt-connected-start-testing | no cancel (can rescan for devices or close)
DaveTryon
reviewed
Jun 22, 2020
src/electron/platform/android/setup/steps/configuring-port-forwarding.ts
Outdated
Show resolved
Hide resolved
These operations can't be canceled because we have no way to interrupt the calls -- we're awaiting promises.
There's no way to cancel the action of the step.
DaveTryon
approved these changes
Jun 22, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The expected behavior of the cancel action for each step is as follows:
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.