Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add scss:build step to yarn fastpass #2931

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

dbjorge
Copy link
Contributor

@dbjorge dbjorge commented Jun 22, 2020

Description of changes

The addition of yarn null:check to yarn fastpass means that fastpass now relies on yarn scss:build having happened first; since that step is relatively quick to execute anyway, this PR adds it to yarn fastpass to avoid users having to remember to do it manually.

Pull request checklist

  • [n/a] Addresses an existing issue: #0000
  • Ran yarn fastpass
  • [n/a] Added/updated relevant unit test(s) (and ran yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [n/a] (UI changes only) Added screenshots/GIFs to description above
  • [n/a] (UI changes only) Verified usability with NVDA/JAWS

@dbjorge dbjorge requested a review from a team as a code owner June 22, 2020 16:55
@dbjorge dbjorge merged commit 3e2824d into microsoft:master Jun 22, 2020
@dbjorge dbjorge deleted the fastpass-implies-scss-build branch June 22, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants