Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(trusted-tester-bugs): fix instance table content color on focus #2975

Merged
merged 1 commit into from
Jun 26, 2020
Merged

feat(trusted-tester-bugs): fix instance table content color on focus #2975

merged 1 commit into from
Jun 26, 2020

Conversation

haonliu
Copy link
Contributor

@haonliu haonliu commented Jun 26, 2020 •
edited
Loading

Description of changes

before: the font color and icon color inside the selected row are all black, which is very hard to see inside a purple background.
after:
image

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@haonliu haonliu requested a review from a team as a code owner June 26, 2020 01:38
@haonliu haonliu merged commit a88ec51 into microsoft:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedAbdoOrtiga AhmedAbdoOrtiga AhmedAbdoOrtiga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haonliu @AhmedAbdoOrtiga