Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updated text case for "Getting started" titles and nav links #3350

Merged
merged 1 commit into from
Sep 14, 2020
Merged

fix: updated text case for "Getting started" titles and nav links #3350

merged 1 commit into from
Sep 14, 2020

Conversation

CorgiDev
Copy link
Contributor

Description of changes

Changed the text case for all instances of "Getting Started" navigation links and page titles to be in sentence case instead of title case to address issue: #3310

This helps to make these text elements more consistent with other similar elements.
"Getting started" text highlighted under "Automated checks" section of Assessment

"Getting started" nav link and header text highlighted under "Headings" section of Assessment

Pull request checklist

  • Addresses an existing issue: #0000
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@CorgiDev CorgiDev requested a review from a team as a code owner September 12, 2020 09:08
@ghost
Copy link

ghost commented Sep 12, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

lisli1
lisli1 approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@lisli1 lisli1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CorgiDev, thank you for submitting a fix for this issue!

@lisli1 lisli1 merged commit 2e15bba into microsoft:master Sep 14, 2020
@lisli1 lisli1 added the good first issue Good for newcomers label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisli1 lisli1 lisli1 approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CorgiDev @lisli1