fix: add corrected text for color contrast tests #3399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shanisebarona
commented
Sep 24, 2020
Comment on lines
57
to
59
| <b> | ||
| Assessment {'>'} Text legibility {'>'} Contrast | ||
| Assessment {'>'} Adaptable content {'>'} Contrast | ||
| </b> |
There was a problem hiding this comment.
I noticed this was previously in bold, so I left as is, but it seems that most of the bold styling is wrapped in <Markup.Term></Markup.Term>. Should this be changed to <Markup.Term> instead?
There was a problem hiding this comment.
Good catch! I agree that it would be an improvement to be consistent about using the semantically-named components; I think reusing Term would be better than using <b> here.
dbjorge
suggested changes
Sep 25, 2020
dbjorge
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Updated the text for the assessment's adaptable content contrast test and fastpass to address issue #3337.
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.