Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inline start over button #3704

Merged
merged 2 commits into from
Dec 2, 2020

Conversation

pownkel
Copy link
Contributor

@pownkel pownkel commented Dec 1, 2020

Description of changes

Replace the "Start over" text in "use the start over button to scan the target page" with an inline button, as described in #3229:

screenshot of inline start over button

screenshot of inline start over button in high contract mode-hicontrast

This affects the "target changed" view in all fastpass pages, and the view before scanning for "automated checks" and "needs review."

Pull request checklist

  • Addresses an existing issue: "Use the Start over button" is unclear now that the button can be hidden behind a ... menu #3229
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@pownkel pownkel requested a review from a team as a code owner December 1, 2020 01:45
@pownkel pownkel requested a review from ferBonnin December 1, 2020 01:52
@ferBonnin
Copy link
Contributor

LGTM 👍
Have we tested the inline button reflows nicely?

@pownkel
Copy link
Contributor Author

pownkel commented Dec 1, 2020

Have we tested the inline button reflows nicely?

Yep! It looks like this:
inlineStartOver-reflow

Copy link
Contributor

@lisli1 lisli1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pownkel pownkel merged commit 922ff33 into microsoft:master Dec 2, 2020
@pownkel pownkel deleted the inline-start-over-button branch December 9, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants