Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text changes in native and custom widgets instructions #3763

Merged
merged 6 commits into from
Dec 17, 2020

Conversation

lisli1
Copy link
Contributor

@lisli1 lisli1 commented Dec 17, 2020

Description of changes

These text changes address #3752, making the instructions better align with WCAG SC 2.5.3 Label in Name.

Screenshot of Native widgets > Instructions
image

Screenshot of Native widgets > Instructions > more info icon
image

Screenshot of Custom widgets > Instructions
image

Screenshot of Custom widgets > Instructions > more info icon
image

Pull request checklist

  • Addresses an existing issue: Text changes in Native widgets & Custom widgets > Instructions #3752
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • [n/a] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@lisli1 lisli1 requested a review from a team as a code owner December 17, 2020 02:41
@lisli1 lisli1 merged commit 6cb55c2 into microsoft:master Dec 17, 2020
@lisli1 lisli1 deleted the lisli1/text-changes-widgets branch July 21, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants