fix: Updating NavLinkButton to announce current page #4677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dated the snapshots for their unit tests to account for the new text
…n have aria-current support for links.
JGibson2019
changed the title
peterdur
reviewed
Sep 13, 2021
| @@ -2187,11 +2187,16 @@ | |||
| resolved "https://registry.yarnpkg.com/@types/ms/-/ms-0.7.31.tgz#31b7ca6407128a3d2bbc27fe2d21b345397f6197" | |||
| integrity sha512-iiUgKzV9AuaEkZqkOLDIvlQiL6ltuZd9tGcW3gwpnX8JbuiuhFlEGmmFXEXkN50Cvq7Os88IY2v0dkDqXYWVgA== | |||
|
|
|||
| "@types/node@*", "@types/node@>= 8", "@types/node@^12.0.12", "@types/node@^14.14.6", "@types/node@^14.17.15": | |||
| "@types/node@*", "@types/node@>= 8", "@types/node@^14.17.15": | |||
There was a problem hiding this comment.
Are all these changes to yarn.lock expected? Many don't seem connected to the office-ui-fabric-react update.
There was a problem hiding this comment.
Yes. When I bumped the office-ui-fabric-react version, it appears that it updated also updated the yarn.lock entries for packages that are dependencies. I believe this happened in the "linking dependencies" and "build fresh packages" steps; that resulted in the reformatting (e.g. moving @types/node@^12.0.12" from line 2190 and creating a separate entry below on 2195.
peterdur
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
When using the Left Nav from results view in Unified, JAWS/NVDA users were not able to know if they had navigated to a list item that was selected or unselected. By adding the "aria-current" attribute to each item, the selected list item is announced as "current page", so they have the necessary context.
Motivation
Addresses the following Unified bug: https://dev.azure.com/mseng/1ES/_workitems/edit/1859838
Context
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.