Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Android export dialog disappears on reflow #4947

Merged
merged 6 commits into from
Dec 1, 2021

Conversation

brocktaylor7
Copy link
Contributor

@brocktaylor7 brocktaylor7 commented Dec 1, 2021

Details

This fixes a reflow issue that causes the export dialog to disappear when it shouldn't. This was because of the button and export dialog being rendered in a single component, so when that component would move to the collapsed menu due to reflow, the export dialog would disappear.

Before with reflow making dialog disappear:
original_unified_resize

After the fix:
new_unified_resize

Motivation

Addresses issue #4492

Context

The diff is a little confusing and it may make sense to look at the first two commits separately. This is due to the fact that we had two components doing the same thing in web and unified. One was called "ReportExportComponent" and one was called "ExportDialogWithLocalState". I much prefer the name "ReportExportComponent" but the code in ExportDialogWithLocalState was much closer to what I needed to unify the two. So I made the changes in ExportDialogWithLocalState in the first commit, then renamed it back to ReportExportComponent in the second commit. (Reach out if there is any confusion :))

I completely removed the entity formerly known as ReportExportComponent (which was only used in Unified).

Pull request checklist

  • Addresses an existing issue: Android: export dialog disappears if window is resized #4492
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@brocktaylor7 brocktaylor7 requested a review from a team as a code owner December 1, 2021 18:14
Copy link
Contributor

@ThanyaLeif ThanyaLeif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nicely done!

@brocktaylor7 brocktaylor7 merged commit e0f37d5 into microsoft:main Dec 1, 2021
@brocktaylor7 brocktaylor7 deleted the fix-export-dialog branch December 1, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants