Fix: Android export dialog disappears on reflow #4947
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This fixes a reflow issue that causes the export dialog to disappear when it shouldn't. This was because of the button and export dialog being rendered in a single component, so when that component would move to the collapsed menu due to reflow, the export dialog would disappear.
Before with reflow making dialog disappear:
After the fix:
Motivation
Addresses issue #4492
Context
The diff is a little confusing and it may make sense to look at the first two commits separately. This is due to the fact that we had two components doing the same thing in web and unified. One was called "ReportExportComponent" and one was called "ExportDialogWithLocalState". I much prefer the name "ReportExportComponent" but the code in ExportDialogWithLocalState was much closer to what I needed to unify the two. So I made the changes in ExportDialogWithLocalState in the first commit, then renamed it back to ReportExportComponent in the second commit. (Reach out if there is any confusion :))
I completely removed the entity formerly known as ReportExportComponent (which was only used in Unified).
Pull request checklist
yarn fastpass
yarn test
)<rootDir>/test-results/unit/coverage
fix:
,chore:
,feat(feature-name):
,refactor:
). SeeCONTRIBUTING.md
.