Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quick-assess-ux): Force Automated Checks nav link to render as a link for Quick Assess #6946

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

madalynrose
Copy link
Contributor

Details

The left nav for Assessments renders all Assessments as buttons because most of them are collapsible and have requirement links under them. Quick Assess' left nav renders all Requirements as links since none are collapsible. The Automated Checks Assessment link used to be collapsible but is non-collapsible since the Automated Checks feature. However, the link is still rendered as a button for both Assessment and Quick Assess. This causes it to have noticeably different styling in Windows High Contrast mode. This PR renders the Automated Checks link as a link for Quick Assess.

HC Theme Quick Assess Before Quick Assess After Assessment Before Assessment After
Night Sky quick assess left nav with all links purple but automated checks is yellow quick assess left nav with all links purple including automated checks assessment left nav with all assessment links yellow assessment left nav with all assessment links yellow
Desert quick assess left nav with all links blue but automated checks is black quick assess left nav with all links blue including automated checks assessment left nav with all assessment links black assessment left nav with all assessment links black
None quick assess left nav with all links black quick assess left nav with all links black assessment left nav with all links black assessment left nav with all links black
Motivation

fixes issue #6547

Pull request checklist

  • Addresses an existing issue: [Windows 11 HC] Quick Assess Automated checks text in navigation bar does not match other tests #6547
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • (UI changes only) Added screenshots/GIFs to description above
  • (UI changes only) Verified usability with NVDA/JAWS

@madalynrose madalynrose requested a review from a team as a code owner September 7, 2023 15:48
@madalynrose madalynrose merged commit 293290e into microsoft:main Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants