fix: No links to needs-review doc pages? #7007 #7133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-sharmachir
changed the title
DaveTryon
reviewed
Dec 11, 2023
src/tests/unit/tests/common/configs/needs-review-rule-resources.test.ts
Outdated
Show resolved
Hide resolved
DaveTryon
reviewed
Dec 11, 2023
DaveTryon
reviewed
Dec 11, 2023
…hir/accessibility-insights-web into bugfix-NeedsReviewLink
DaveTryon
reviewed
Jan 30, 2024
DaveTryon
reviewed
Jan 30, 2024
DaveTryon
reviewed
Jan 30, 2024
src/tests/unit/tests/common/components/cards/__snapshots__/rule-resources.test.tsx.snap
Outdated
Show resolved
Hide resolved
DaveTryon
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Bug fix to use needs-review document pages for the Needs review tab link. None of the needs-review document pages were referenced anywhere inside the web extension. Some of the rules that show up in the Needs review tab link have document page available but the url under needs review were of either automated check rule url.
The fix used is, In the rule-resources.tsx file we are checking if the tab selected is needs-review on the basis of the outcome type and added a new file named needs-review-rule-resources.tsx is used to create the needs review url on the basis of rules present in the document page.
Motivation
fix: No links to needs-review doc pages? #7007
Context
Pull request checklist
yarn fastpassyarn test)<rootDir>/test-results/unit/coveragefix:,chore:,feat(feature-name):,refactor:). SeeCONTRIBUTING.md.