fix: Accessibility Bugs

[madalynrose]

Details

This PR fixes two accessibility bugs:

• QuickAssessToAssessmentDialog does not redirect focus to the trigger button after it closes
  • before video
  • after video
• Failure instance visual helper checkbox in issues table does not correctly update aria-checked/checked when it is toggled
  • before video
  • after video

Motivation

Accessibility Compliance

Context

For the dialog close focus bug, I moved the QuickAssessToAssessmentDialog to be inside the DetailsViewCommandBar like the other buttons that open dialogs. I managed focus the same way we do for the ReportExportDialog.

For the visual helper checkbox bug, we were only setting aria-checked and not checked on the checkbox, so now we explicitly set the checked attribute (which in turn updates aria-checked).

Pull request checklist

• [N/A] Addresses an existing issue: #0000
• Ran yarn fastpass
• Added/updated relevant unit test(s) (and ran yarn test)
• Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
• PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
• (UI changes only) Added screenshots/GIFs to description above
• (UI changes only) Verified usability with NVDA/JAWS