Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppStoreRelease task has been updated - '--automatic_release' key will be set to 'true\false' regardless of the shouldAutoRelease parameter #239

Conversation

andy-mishechkin
Copy link
Contributor

Task name: AppStoreRelease

Description: In previous version --automatic_release key will be set to 'true only if shouldAutoRelease task parameter is present and set to true. According to http://docs.fastlane.tools/actions/deliver/#parameters --automatic_release has no default value and should be set in any cases. This will be fixed in this PR - --automatic_release will be set to true or false, if shouldAutoRelease is present and set to true or is absent or set to false.

Documentation changes required: N

Added unit tests: (Y/N) N

Attached related issue: #235

Checklist:

@andy-mishechkin andy-mishechkin requested a review from a team May 6, 2021 11:24
Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@anatolybolshakov anatolybolshakov requested a review from a team May 7, 2021 08:23
@anatolybolshakov anatolybolshakov merged commit c44cf12 into master May 11, 2021
@max-zaytsev max-zaytsev deleted the users/andy-mishechkin/fix235_AppStoreRelease_shouldAutoReleaseSetToFalse_issue branch May 28, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants