Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow specifying external tester groups when uploading to test flight… #80

Merged
merged 1 commit into from
Nov 6, 2017

Conversation

madhurig
Copy link
Contributor

@madhurig madhurig commented Nov 2, 2017

…, allow passing fastlane arguments

Fixes issue #70, #71

@@ -165,6 +165,8 @@ async function run() {
tl.debug('Skipped fastlane installation.');
}

let fastlaneArguments: string = tl.getInput('fastlaneArguments');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: const over let

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other spots in this file too, will update all of them next time.

Copy link
Contributor

@lkillgore lkillgore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@madhurig madhurig merged commit b358042 into master Nov 6, 2017
@madhurig madhurig deleted the users/madhurig/testgroups branch November 6, 2017 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants