Merge pull request #114 from Microsoft/fix/setCustomProperties-bug

Fix a bug in setCustomProperties where boolean property is always set to true
microsoft · Sep 13, 2017 · 455a4e3 · 455a4e3
2 parents 9906d92 + b807db7
commit 455a4e3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/TestApp/MobileCenterScreen.js b/TestApp/MobileCenterScreen.js
@@ -75,6 +75,7 @@ export default class MobileCenterScreen extends React.Component {
       .clear('old')
       .set('color', 'blue')
       .set('optin', true)
+      .set('optout', false)
       .set('score', 7)
       .set('now', new Date());
     await MobileCenter.setCustomProperties(properties);

diff --git a/mobile-center/ios/RNMobileCenter/RNMobileCenter.m b/mobile-center/ios/RNMobileCenter/RNMobileCenter.m
@@ -85,7 +85,8 @@ + (void)register
                     [customProperties setNumber:value forKey:key];
                 }
                 else if ([typeString isEqualToString:@"boolean"]) {
-                    [customProperties setBool:value forKey:key];
+                    NSNumber *num = value;
+                    [customProperties setBool:[num boolValue] forKey:key];
                 }
                 else if ([typeString isEqualToString:@"date-time"]) {
                     NSDate *date = [RCTConvert NSDate:value];