Fix a bug where Analytics is always enabled even Analytics is set to "Enable in JavaScript" #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When Analytics is set to "Enable in JavaScript" in the following question in
react-native link
:Analytics is supposed to remain disabled until
await Analytics.setEnabled(true);
called in JavaScript code. But Analytics is not disabled in this case. This issue exists in both iOS and Android. It is not affecting other services (e.g. Crashes service).Root cause:
Analytics.setEnabled(false);
should not be called before Analytics service is started.Fix: Start Analytics before calling
.setEnabled(false)
.