Fix ios linking issue #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dhei, |
guperrot
approved these changes
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-native linkis broken for iOS projects due to #107.There are two issues with #107:
(1)
initInAppDelegate(header, initCode, oldInitCodeRegExp)in /mobile-center-link-scripts/src/ios/index.js has inconsistent return types. It returns a string in success but a Promise in failure. This caused a runtime error when callinginitInAppDelegateinreact-native linkon iOS project.(2) postlink.js in mobile-center is missing a
returnin the arrow function (this line) in the promise chaining. This causedreact-native linkprompting user for iOS appsecret without waiting for user input. This issue exists for mobile-center-analytics, mobile-center-push, mobile-center-crashes module.This PR addresses the above issues and tested on blank new RN apps (iOS & Android).