fix all Framework imports that would break cocoapods installation

[DulMephistos]

This PR will fix cocoapods integration for the libraries appcenter, appcenter-crashes and appcenter-push. They're currently failing due to wrong use of @import statements inside its headers and implementation files. These libraries should build without the need to import AppCenter directly, just by knowing theirs .h files.

The issue can be demonstrated if you try to integrate using purely cocoapods and not by adding the xcode project files inside your project. If done so you should get an error like this one:

▸ Compiling AppCenterReactNative.m

AppCenterReactNativeShared/AppCenterReactNativeShared/AppCenterReactNativeShared.h:3:9: module 'AppCenter' not found

This change removes that import from the header file and replaces it with a Forward Declaration of the class or protocol if needed. Then inside the implementation file the needed header is imported using #import <Framework/Header.h> format instead of the module format, that should work for all cases.

[msftclas]

All CLA requirements met.

[bmourat]

Don't we need some header for MSWrapperSdk type?

[bmourat]

Also in AppCenterReactNativeShared.m file we need header for MSAppCenter type

[DulMephistos]

You're right.. I wasn't able to properly build the framework before, not sure why but it should be good to go now. Built and checked.
I've use forward declaration on the header and imported the right header in the .m file, still not requiring a @import which has been the issue for our integration flow.

[bmourat]

Missing empty line before protocol

[DulMephistos]

✅

[DulMephistos]

let me know how does it look now guys. Thank you!

[bmourat]

The build fails for the TestApp, as for the newly created app. Here is the error message:
...../TestApp/node_modules/appcenter/ios/AppCenterReactNative/AppCenterReactNative.m:20:9: 'AppCenterReactNativeShared/AppCenterReactNativeShared.h' file not found.
Adding folder to Headers search path fixes the issue.
I think this was not the case because we were using import module syntax, but this is not 100%.

[DulMephistos]

That's odd because here it's all normal. I've run the script inside the TestApp called update-link-to-appcenter.sh, then opened Xcode and it built everything without any issues on my machine. Check this screenshot that specifically shows the compile log of this file.

The only two things that I noticed were:

• The header inside the /AppCenterReactNativeShared.framework was not updated (just committed that)
• And that Xcode produces a lot of changes after linking with that script, but I believe those are just a bunch of IDs that change inside .xcodeproj file on linking and will change every time.

Please let me know if you have more documentation on how to run all the tests you guys run on a PR. I might have missed something in the process. I didn't find docs for contributing.

[bmourat]

That's strange now everything compiles, maybe that is because I was performing all those operations manually and missed something.

[DulMephistos]

@bmourat hey.. any idea of when this will be merged into develop or master? We're currently blocked on this to make AppCenter integration work on iOS. Thanks!

[guperrot]

Hi, we release our SDKs the third week of the month. If you need packages before you can run scripts/npm-pack.sh on your branch and use those locally or in a private or non official repo. As for merging we will do it soon but release will come later after the merge.

[DulMephistos]

Great! thanks for the quick response @guperrot

[dhei]

Hey @fcerdeiral, thanks for the contribution, your PR is merged and will be shipped in our June SDK release.