-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration to delay the first start of Push until Push.setEnabled(true) is called from JS #480
Conversation
...d/src/main/java/com/microsoft/appcenter/reactnative/push/AppCenterReactNativePushModule.java
Outdated
Show resolved
Hide resolved
...d/src/main/java/com/microsoft/appcenter/reactnative/push/AppCenterReactNativePushModule.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking maybe use this API in TestApp?
Hi guys, |
@jdnichollsc it works for us in TestApp from this repo but it looks like your issue is caused by something else since you commented on #505. |
@guperrot thanks, I'm reviewing the code of AppCenter but I can't see any issue |
Things to consider before you submit the PR:
CHANGELOG.md
been updated?Description
To delay start push with this change:
"enable_push_in_javascript": true
to appcenter-config.jsonPush.setEnabled(true)
from Javascript when developer wants to start Push.Since this is only for the first time we want to delay Push, the code also remembers the first call to
Push.setEnabled(true)
and will start Push automatically the next time.Documentation PR: https://github.com/MicrosoftDocs/appcenter-docs-pr/pull/1000
Requested in #287