Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix push :verifyReleaseResources without breaking :lint #484

Merged
merged 4 commits into from
Dec 12, 2018
Merged

Fix push :verifyReleaseResources without breaking :lint #484

merged 4 commits into from
Dec 12, 2018

Conversation

guperrot
Copy link
Member

@guperrot guperrot commented Dec 11, 2018 •
edited
Loading

Things to consider before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Fix for issue #481

dhei
dhei previously approved these changes Dec 11, 2018
View reviewed changes
thyeggman
thyeggman previously approved these changes Dec 11, 2018
View reviewed changes
@guperrot guperrot dismissed stale reviews from thyeggman and dhei via a711f24 December 12, 2018 02:12
@dhei dhei merged commit fd0d573 into develop Dec 12, 2018
@dhei dhei deleted the fix/push-verifyReleaseResources branch December 12, 2018 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhei dhei dhei approved these changes

@thyeggman thyeggman thyeggman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guperrot @dhei @thyeggman