Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit react-native-screens dependency to the TestApp #814

Merged
merged 2 commits into from
Mar 19, 2020

Conversation

russelarms
Copy link
Contributor

@russelarms russelarms commented Mar 19, 2020

Things to consider before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

react-navigation-tabs package has react-native-screens as a peerDependency, which means it is not downloaded automatically when using npm i. It used to work because react-native-screens was required by react-navigation/native@3.3.0

"@react-navigation/native": {
"version": "3.3.0",
"resolved": "https://registry.npmjs.org/@react-navigation/native/-/native-3.3.0.tgz",
...
"requires": {
"hoist-non-react-statics": "^3.0.1",
"react-native-safe-area-view": "^0.13.0",
"react-native-screens": "^1.0.0 || ^1.0.0-alpha"
},

But react-navigation/native@3.6.5 doesn't have an explicit dependency on react-native-screens anymore:

"@react-navigation/native": {
"version": "3.6.5",
"resolved": "https://registry.npmjs.org/@react-navigation/native/-/native-3.6.5.tgz",
...
"requires": {
"hoist-non-react-statics": "^3.3.2",
"react-native-safe-area-view": "^0.14.8"
},

Related PRs or issues

AB#78100

@russelarms russelarms changed the title Add explicit react-native-screens dependency Add explicit react-native-screens dependency to the TestApp Mar 19, 2020
@MatkovIvan
Copy link
Contributor

It looks like revert of #806

@russelarms
Copy link
Contributor Author

@MatkovIvan It is needed anyway, without it, the app won't build.
The difference between the two is that DemoApp uses RN 0.59 and TestApp uses RN 0.61, they use different build flows.
It was linked the wrong way on DemoApp, that's why we applied #806

@dhei dhei merged commit 9796f36 into develop Mar 19, 2020
@dhei dhei deleted the fix/test-app-react-native-screens branch March 19, 2020 22:40
@russelarms russelarms mentioned this pull request Mar 24, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants