Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix App Center build #886

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Fix App Center build #886

merged 1 commit into from
Dec 28, 2020
+0 −5

Conversation

russelarms
Copy link
Contributor

Things to consider before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

The build failed because of incompatibility between appcompat and androidx dependencies:

    Attribute application@appComponentFactory value=(android.support.v4.app.CoreComponentFactory) from [com.android.support:support-compat:28.0.0] AndroidManifest.xml:22:18-91
    is also present at [androidx.core:core:1.1.0] AndroidManifest.xml:24:18-86 value=(androidx.core.app.CoreComponentFactory).

Related PRs or issues

#806

@russelarms russelarms changed the base branch from develop to master December 28, 2020 09:16
@russelarms russelarms marked this pull request as ready for review December 28, 2020 09:19
@MatkovIvan MatkovIvan merged commit 7541023 into master Dec 28, 2020
@MatkovIvan MatkovIvan deleted the release/ac-build-fix branch December 28, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatkovIvan MatkovIvan MatkovIvan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@russelarms @MatkovIvan