-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse and correctly set Gemini safety settings #3026
Conversation
@microsoft-github-policy-service agree |
@drewgillson thanks for the contribution, could you fix the code formatting issue by running pre-commit? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! What if VertexAI is not used? For instance, what if the user is using google-generativeai rather than VertexAI?
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
Hi @drewgillson, could you fix code format issues? Thanks! |
@drewgillson would you like to continue working on this PR? |
@drewgillson - this is a few months stale - we've rebased and updated the branch and its been a couple weeks since, closing for now and please reopen if you would like to continue. |
Why are these changes needed?
The provided example at the top of this file did not work correctly. Safety settings need to be parsed into Vertex AI objects and cannot just be a dictionary of simple objects.
Checks