Exposing TLS Configuration via Connection (#84)

* Exposing client variables * Exposing TLS Config via Connection * Merge issue
microsoft · Aug 12, 2020 · 809f645 · 809f645
1 parent 0eaf2fc
commit 809f645
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/azuredevops/client.go b/azuredevops/client.go
@@ -51,7 +51,14 @@ var versionSuffix = " (dev)"
 var baseUserAgent = "go/" + runtime.Version() + " (" + runtime.GOOS + " " + runtime.GOARCH + ") azure-devops-go-api/" + version + versionSuffix
 
 func NewClient(connection *Connection, baseUrl string) *Client {
-	client := &http.Client{}
+	var client *http.Client
+
+	if connection.TlsConfig != nil {
+		client = &http.Client{Transport: &http.Transport{TLSClientConfig: connection.TlsConfig}}
+	} else {
+		client = &http.Client{}
+	}
+
 	if connection.Timeout != nil {
 		client.Timeout = *connection.Timeout
 	}

diff --git a/azuredevops/connection.go b/azuredevops/connection.go
@@ -5,11 +5,13 @@ package azuredevops
 
 import (
 	"context"
+	"crypto/tls"
 	"encoding/base64"
-	"github.com/google/uuid"
 	"strings"
 	"sync"
 	"time"
+
+	"github.com/google/uuid"
 )
 
 // Creates a new Azure DevOps connection instance using a personal access token.
@@ -38,6 +40,7 @@ type Connection struct {
 	SuppressFedAuthRedirect bool
 	ForceMsaPassThrough     bool
 	Timeout                 *time.Duration
+	TlsConfig               *tls.Config
 	clientCache             map[string]Client
 	clientCacheLock         sync.RWMutex
 	resourceAreaCache       map[uuid.UUID]ResourceAreaInfo