Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: UnmarshalCollectionBody does not return all errors #48

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Fix: UnmarshalCollectionBody does not return all errors #48

merged 1 commit into from
Mar 11, 2020

Conversation

tmeckel
Copy link
Contributor

@tmeckel tmeckel commented Jan 10, 2020

This PR contains a fix for UnmarshalCollectionBody, so that all (internal) errors are returned by the function to the caller.

@tmeckel
Copy link
Contributor Author

tmeckel commented Feb 2, 2020

@tedchamb any chances that this get merged in the near future?

@tmeckel tmeckel requested a review from tedchamb February 2, 2020 19:20
@tedchamb
Copy link
Member

@tmeckel , thanks for contributing!

@tedchamb tedchamb merged commit 17093eb into microsoft:dev Mar 11, 2020
@tmeckel tmeckel deleted the fix-unmarshalcollectionbody branch March 11, 2020 18:00
@tmeckel
Copy link
Contributor Author

tmeckel commented Mar 11, 2020

@tedchamb would be great if you could fix #47 because we're relying on this fix to implement permission settings in the Azure DevOps Terraform provider (microsoft/terraform-provider-azuredevops#238). Currently we're building from a patched vendor version of the Go API what is definitely NOT ideal.

@tedchamb
Copy link
Member

@tmeckel , sorry for the slow turn around on these. I have a new job, so spending a lot of time ramping up there. When I can carve out some time for the open issues, I will try and tackle as many as I can in one sitting.

@tmeckel
Copy link
Contributor Author

tmeckel commented Mar 12, 2020

@tedchamb same with the guys started the DevOps Terraform Provider. They got new assignments as well but Microsoft forgot to assign new resources. Too bad because especially the Terraform Provider could be of great support for people managing Azure DevOps organizations. I already tried to rouse the people in the DevOps product team via my contacts to the local Microsoft Customer Success Managers in Germany. But so far no luck 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants