Expand the possible time formats that can be unmarshalled from JSON payloads #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedchamb
reviewed
May 14, 2020
nmiodice
force-pushed
the
niiodice/time-fix
branch
from
31e58f5 to
ff7ae62
Compare
|
I've rebased off of the latest code and also fixed a merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Azure DevOps service does not use a consistent time format across APIs. This change makes response unmarshalling more flexible by adding a number of fallback for a variety of time formats.
Note The
azuredevops.Timeimplementation has been moved frommodels.gototime.go. Related tests have also moved totime_test.go.This closes #59