Upgrade to latest typed-rest-client #206
Conversation
|
This may be a breaking change as I think before they could instantiate the handlers directly if they wanted to? If so, will have to bump major. |
|
The other option is to leave those modules in place (api/handlers/...) but have them load and return the handlers from the rest client? |
This reverts commit 7ae7a55.
|
Let's merge, @bryanmacfarlane up to you how to patch. Minor should be fine. |
api/VsoClient.ts
Outdated
| return value; | ||
| } | ||
|
|
||
| protected getValueString(queryValue, value) { |
There was a problem hiding this comment.
Good call, updated it appropriately.
| @@ -52,15 +54,34 @@ export interface IBasicCredentials { | |||
| password: string; | |||
| } | |||
|
|
|||
| export interface IHttpClient { | |||
There was a problem hiding this comment.
Do we need to export this?
There was a problem hiding this comment.
I think we need to export both this and IRequestInfo because we're using them as parameters in other interfaces that are being exported. If I don't export them, an error is thrown Parameter 'httpClient' of method from exported interface has or is using private name 'IHttpClient'.
| requestRawWithCallback(info: IRequestInfo, data: string | NodeJS.ReadableStream, onResult: (err: any, res: IHttpClientResponse) => void): void; | ||
| } | ||
|
|
||
| export interface IRequestInfo { |
Due to shifting interfaces, some changes had to be made, especially to make the handlers compatible.
Resolves #155 and resolves #175
In addition, fixes how dates and other objects are serialized.
Fixes #98, fixes #191, and fixes #199