Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the selection for HttpTrigger's authLevel property #70

Merged
merged 3 commits into from
Dec 15, 2017
Merged

add the selection for HttpTrigger's authLevel property #70

merged 3 commits into from
Dec 15, 2017

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Dec 13, 2017

issue: #67

@jdneo jdneo self-assigned this Dec 13, 2017
adashen
adashen reviewed Dec 13, 2017
View reviewed changes
azure-functions-maven-plugin/src/main/java/com/microsoft/azure/maven/function/AddMojo.java Outdated
@@ -274,18 +276,38 @@ protected void preparePackageName() throws MojoFailureException {
for (final String property : template.getMetadata().getUserPrompt()) {
info(format("Trigger specific parameter [%s]", property));

final List<String> options = OptionTypedProperty.get(property) == null ?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about just one method call like getOptionsforProperty?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

@codecov-io
Copy link

Codecov Report

Merging #70 into master will decrease coverage by 12.6%.
The diff coverage is 52.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #70       +/-   ##
==========================================
- Coverage   78.71%   66.1%   -12.61%     
==========================================
  Files          44      44               
  Lines        1334    1366       +32     
  Branches      137     144        +7     
==========================================
- Hits         1050     903      -147     
- Misses        227     411      +184     
+ Partials       57      52        -5
Impacted Files Coverage Δ
...va/com/microsoft/azure/maven/function/AddMojo.java 69.34% <52.63%> (-6.11%) ⬇️
...ft/azure/maven/webapp/handlers/HandlerFactory.java 0% <0%> (-100%) ⬇️
.../maven/webapp/handlers/NullRuntimeHandlerImpl.java 0% <0%> (-100%) ⬇️
.../maven/webapp/handlers/FTPArtifactHandlerImpl.java 0% <0%> (-100%) ⬇️
...ure/maven/webapp/handlers/SettingsHandlerImpl.java 0% <0%> (-81.82%) ⬇️
...crosoft/azure/maven/webapp/AbstractWebAppMojo.java 0% <0%> (-77.78%) ⬇️
...a/com/microsoft/azure/maven/webapp/DeployMojo.java 0% <0%> (-76.6%) ⬇️
...pp/handlers/PublicDockerHubRuntimeHandlerImpl.java 0% <0%> (-70%) ⬇️
...zure/maven/webapp/handlers/HandlerFactoryImpl.java 0% <0%> (-66.67%) ⬇️
.../maven/webapp/handlers/JavaRuntimeHandlerImpl.java 0% <0%> (-64.29%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 323ee2f...0c19162. Read the comment docs.

@jdneo jdneo mentioned this pull request Dec 13, 2017
Closed
@jdneo jdneo merged commit 5d1e1f8 into master Dec 15, 2017
@jdneo jdneo deleted the cs/authlevel branch December 15, 2017 03:37
@jdneo jdneo mentioned this pull request Dec 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adashen adashen adashen approved these changes

@xscript xscript Awaiting requested review from xscript

Assignees

@jdneo jdneo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdneo @codecov-io @adashen