Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setSanitizedResult function #1022

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

onetocny
Copy link
Contributor

There were several cases when we observed sensitive data (such as passwords) leakage through task.setResult function. To prevent such behavior this PR introduces setSanitizedResult function that truncates the passed message before first occurrence of well known sensitive keyword. For more details see the original incident or its repair item.

@onetocny onetocny requested review from a team as code owners February 15, 2024 11:37
Copy link
Contributor

@DenisNikulin5 DenisNikulin5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@onetocny onetocny merged commit f1a07a7 into master Feb 15, 2024
6 checks passed
@onetocny onetocny deleted the users/onetocny/sanitize_result_message branch February 15, 2024 12:31
ivanduplenskikh pushed a commit that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants