Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CodeQL fail tests #1034

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Fix CodeQL fail tests #1034

merged 5 commits into from
Apr 11, 2024

Conversation

DmitriiBobreshev
Copy link
Contributor

@DmitriiBobreshev DmitriiBobreshev commented Apr 11, 2024

Description:
The problem with CodeQL was that the CodeQL injects into Agent.Worker Process and change behaviour of the child_process.spawn command, specifically, when the cwd path is not exists UNKNOWN error is thrown before the spawn method will create the child_process events. The changes just add try-catch for that case in toolrunner

@DmitriiBobreshev DmitriiBobreshev marked this pull request as ready for review April 11, 2024 15:26
@DmitriiBobreshev DmitriiBobreshev requested review from a team as code owners April 11, 2024 15:26
@DergachevE DergachevE merged commit 70d4711 into master Apr 11, 2024
6 checks passed
@DmitriiBobreshev DmitriiBobreshev deleted the user/v-bobreshevd/fix-flaky-tests branch April 12, 2024 07:37
KonstantinTyukalov pushed a commit that referenced this pull request Apr 29, 2024
* Fix CodeQL fail tests

- Fixed error when the spawn method couldn't execute

* temporary enable codeql for all branches

* Revert "temporary enable codeql for all branches"

This reverts commit 69443a0.

* Increase timeout for codeql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants