Fix ToolRunner stdline/errline events buffering #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _processLineBuffer method is incorrectly buffering line data since the buffer is being passed as a string and thus changes to the buffer preformed in the method are not persisted. The fix is to use an object with a string property as the buffer.
KonstantinTyukalov
changed the title
vmapetr
approved these changes
Aug 6, 2024
…-task-lib into users/KonstantinTyukalov/Fix_toolrunner_line_buffering
KonstantinTyukalov
force-pushed
the
users/KonstantinTyukalov/Fix_toolrunner_line_buffering
branch
from
b0a2350 to
214eaf4
Compare
DergachevE
approved these changes
Sep 9, 2024
kirill-ivlev
approved these changes
Sep 9, 2024
KonstantinTyukalov
deleted the
users/KonstantinTyukalov/Fix_toolrunner_line_buffering
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WI: #1032
Based on these changes: #1030
Buffers for 'stdline' and 'errline' events are not working correctly as buffer variables are value types not changed by reference.
changed the code to store new buffer values correctly.
Also, fixed the
emitDoneEventcall context to fix buffers flushing.Tested: unit test