Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for checks not failing on compilation error #1068

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Fix for checks not failing on compilation error #1068

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
837fc0c
added tsc -v
merlynomsft Sep 25, 2024
eac026f
use' npm tsc'
merlynomsft Sep 25, 2024
71a65b8
npx
merlynomsft Sep 25, 2024
c756318
fix build not failing on compile error
merlynomsft Sep 25, 2024
a7c0a7b
compile error test
merlynomsft Sep 25, 2024
81e04e6
Revert "compile error test"
merlynomsft Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions node/make.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,6 @@ var rp = function (relPath) {
var buildPath = path.join(__dirname, '_build');
var testPath = path.join(__dirname, '_test');

if (process.env['TF_BUILD']) {
// the CI controls the version of node, so it runs using "node make.js test" instead of "npm test"
// update the PATH when running during CI
buildutils.addPath(path.join(__dirname, 'node_modules', '.bin'));
}

target.clean = function () {
rm('-Rf', buildPath);
rm('-Rf', testPath);
Expand All @@ -26,7 +20,8 @@ target.build = function() {
target.clean();
target.loc();

run('tsc --outDir ' + buildPath);
run('npx tsc -v');
run('npx tsc --outDir ' + buildPath);
cp(rp('package.json'), buildPath);
cp(rp('package-lock.json'), buildPath);
cp(rp('README.md'), buildPath);
Expand Down Expand Up @@ -71,9 +66,11 @@ target.loc = function() {
process.on('uncaughtException', err => {
console.error(`Uncaught exception: ${err.message}`);
console.debug(err.stack);
exit(1);
});

process.on('unhandledRejection', err => {
console.error(`Unhandled rejection: ${err.message}`);
console.debug(err.stack);
exit(1);
});