#667 Error setting resourceFile: "Maximum call stack size exceeded" #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xceeded" + Preventing the infinite recustion by not translating warning about missing translation.
|
@cima thanks for the fix here! |
- Getting rid of unnecessary escaping backslash
|
|
|
@anatolybolshakov I have taken a look at it and I wasn't happy with my own code. I've just add a brief unit test to be able to put breakpoint and debug and discovered two things:
I have compile it, run tests and the fix is pushed in the branch. |
Package lock remains almost untouched as no version has been changed.
The missing file lib.json is simulated via resporting nonexistent file via mockery.
anatolybolshakov
approved these changes
Oct 1, 2021
AnnaOpareva
approved these changes
Oct 5, 2021
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
fullstackinfo
pushed a commit
to fullstackinfo/azure-pipelines-task-lib
that referenced
this pull request
Aug 17, 2024
…xceeded" (microsoft#773) * microsoft#667 Error setting resourceFile: "Maximum call stack size exceeded" + Preventing the infinite recustion by not translating warning about missing translation. * Wrong variable in warning output. - Getting rid of unnecessary escaping backslash * Bumping package version * Missing Localization test using mockery The missing file lib.json is simulated via resporting nonexistent file via mockery. Co-authored-by: Martin Šimek <martin.simek@digiteqautomotive.com> Co-authored-by: Anatoly Bolshakov <anatoly.bolshakov@akvelon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see and reopen issue #667 . What I provide here is fix of catastrphic failure in infinite recursion. It doesn't fix translation in compilation systems like webpack.