Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DotNetCoreCLI - Pack missing doc & wierd usage #10831

Open
Herve-M opened this issue Jul 5, 2019 · 16 comments
Open

DotNetCoreCLI - Pack missing doc & wierd usage #10831

Herve-M opened this issue Jul 5, 2019 · 16 comments

Comments

@Herve-M
Copy link

Herve-M commented Jul 5, 2019

Note

This could be related to issue #9789

Required Information

Question, Feature?
Type: Feature / Cleaning
Enter Task Name: DotNetCoreCLIV2

Environment

  • Server - Azure Pipelines
  • Agent - Hosted

Issue Description

DotNetCoreCLI@2 provide a documented way for packing, who is I think mispelling / hard to get into / easier to get lost.

Like:

- task: DotNetCoreCLI@2
  displayName: 'Pack - Manager'
  inputs:
    command: 'pack'
    projects: '$(Build.SourcesDirectory)/src/CM/CM.csproj'
    includesymbols: true
    includesource: true
    nobuild: true
    verbosityPack: 'normal'
    outputDir: '$(Build.StagingDirectory)'

projects won't be used during pack cmd and will be override by searchPatternPack who is required but has a default. And it seem to have one alias packagesToPack who is not set or documented.

@ghost ghost assigned sachinma Jul 5, 2019
@sachinma sachinma added Area: ArtifactsPackages Azure Artifacts Packaging Team and removed Area: Release labels Jul 5, 2019
@sachinma sachinma removed their assignment Jul 5, 2019
@Trolldemorted
Copy link

I just lost several hours because of this bug. Could you emit a warning if projects is used in combination with pack and link to this issue @sachinma ?

@phil-hodgson phil-hodgson removed the Area: ArtifactsPackages Azure Artifacts Packaging Team label Nov 14, 2019
@madhurig madhurig removed their assignment May 19, 2020
@github-actions
Copy link

This issue is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days

@github-actions github-actions bot added the stale label Nov 15, 2020
@Trolldemorted
Copy link

Was this fixed in the meanwhile?

@github-actions github-actions bot removed the stale label Nov 16, 2020
@github-actions
Copy link

This issue is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days

@github-actions github-actions bot added the stale label May 28, 2021
@Trolldemorted
Copy link

Was this fixed in the meanwhile?

@github-actions github-actions bot removed the stale label May 28, 2021
@github-actions
Copy link

This issue is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days

@github-actions github-actions bot added the stale label Nov 24, 2021
@Trolldemorted
Copy link

Was this fixed in the meanwhile?

@github-actions github-actions bot removed the stale label Nov 25, 2021
@dferretti
Copy link

Also I think there are differences between projects and searchPatternPack - I am able to pass a multiline string to projects for a restore or build command, but not pack. For example I am trying to build a reusable template to restore/build/pack like this:

parameters:
- name: projects
  type: string
steps:
- task: DotNetCoreCLI@2
  inputs:
    command: restore
    projects: ${{ parameters.projects }} # other options omitted
- task: DotNetCoreCLI@2
  inputs:
    command: build
    projects: ${{ parameters.projects }}
- task: DotNetCoreCLI@2
  inputs:
    command: pack
    searchPatternPack: ${{ parameters.projects }}

however, if I try to use this template with a multiline string, only restore and build succeed:

variables:
  projects: |
    some/project/A.csproj
    other/project/B.csproj
- template: my-template
  parameters:
    projects: $(projects)

Those 2 projects will be found by the restore and build tasks and work fine, but the pack task seems to use different logic for discovering projects and requires a ; separated string instead of newline. So it will fail saying No files matched the search pattern

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

This issue is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days

@github-actions github-actions bot added the stale label Nov 9, 2022
@Trolldemorted
Copy link

Was this fixed in the meanwhile?

@github-actions github-actions bot removed the stale label Nov 9, 2022
@github-actions
Copy link

github-actions bot commented May 9, 2023

This issue is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days

@github-actions github-actions bot added the stale label May 9, 2023
@Trolldemorted
Copy link

Was this fixed in the meanwhile?

@github-actions github-actions bot removed the stale label May 9, 2023
Copy link

github-actions bot commented Nov 5, 2023

This issue is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days

@github-actions github-actions bot added the stale label Nov 5, 2023
@Trolldemorted
Copy link

Was this fixed in the meanwhile?

@github-actions github-actions bot removed the stale label Nov 5, 2023
Copy link

github-actions bot commented Aug 8, 2024

This issue is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days

@github-actions github-actions bot added the stale label Aug 8, 2024
@Trolldemorted
Copy link

Was this fixed in the meanwhile?

@github-actions github-actions bot removed the stale label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants