Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DotNetCoreCLI commands are inconsistent #9789

Closed
weshaggard opened this issue Mar 11, 2019 · 9 comments
Closed

DotNetCoreCLI commands are inconsistent #9789

weshaggard opened this issue Mar 11, 2019 · 9 comments

Comments

@weshaggard
Copy link
Member

The DotNETCoreCLI task supports various commands however they all seem to be inconsistent. A couple examples:

arguments: While the task supports an optional arguments parameter it doesn't get used by all the tasks. I was trying to pass additional augments to the pack command and while the YAML accepts it the pack command completely ignores it.

Another example is the verbosity parameter some if you check out the documentation you see "verbosity" listed twice in the doc table and in the same command you see it listed at verbosityRestore and verbosityPack. Is there really any reason that all the commands cannot simply use verbosity as it is a common option for all.

Please work on cleaning up this task to make the different commands consistent and only add additional parameters for things that are truly unique for the given command. At this point to workaround these I will need to stop using the DotNETCoreCLI task and make the call directly with a script.

weshaggard added a commit to weshaggard/azure-sdk-for-net that referenced this issue Mar 11, 2019
The DotNETCoreCLI task doesn't support extra arguments when calling
the pack command so we need to directly call pack instead. see
microsoft/azure-pipelines-tasks#9789
@issacnitin
Copy link
Contributor

@weshaggard Thank you for the feedback, I agree the commands are inconsistent right now and need cleanup. We'll start working on this as soon as possible.

mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this issue Jun 10, 2019
The DotNETCoreCLI task doesn't support extra arguments when calling
the pack command so we need to directly call pack instead. see
microsoft/azure-pipelines-tasks#9789
@hiyadav hiyadav self-assigned this Sep 12, 2019
@OliverRC
Copy link

OliverRC commented Oct 24, 2019

I agree, pack should allow arguments to be passed.

@smileyiori
Copy link

Even if you pass the arguments, the CLI does not execute them.
In my case I set nobuild: true
image

and my command looks like:
image

But the project still building. Is there something related?

@dmcweeney
Copy link

Just some feedback here - this is painful for me at the moment - after introducing second repo into the build script all the dotnet commands are failing - trying to use the workingDirectory property to fix it but its not supported by some of the dotnet commands and the docs dont clarify

@bishal-pdMSFT
Copy link
Contributor

Cc @tejasd1990 @pulkitaggarwl

@sayedsaad07
Copy link

Any updates on this issue please
I tried different combinations but nothing seems to work
Working-directory is ignored
even below does not work
dotnet restore ${{github.workspace}}/webapi

@github-actions
Copy link

This issue is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days

@github-actions github-actions bot added the stale label Jun 24, 2021
@dmcweeney
Copy link

Hi @bishal-pdMSFT any update on this?

@github-actions
Copy link

This issue is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests