Update IonQBackend to handle circuit lists of size one #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
I re-verified the claim I'd made about
|
Co-authored-by: Guen Prawiroatmodjo <guenp@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
guenp
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #200
Qiskit's
BackendV1supports lists of circuits in itsrunmethod. This isn't implemented in azure-quantum and qiskit-ionq, which means that passing a list results in confusing exceptions. A while ago, qiskit-ionq added some changes that make it possible to handle circuit lists of length 1 and also added more explicit error messages (see qiskit-community/qiskit-ionq#71). They also have an issue for adding multi-circuit experiment support in the future (see qiskit-community/qiskit-ionq#70).I believe it would make sense to do the same in azure-quantum, because currently some of Qiskit's features are not usable. I reported this issue in #200.
To make Qiskit's features such asMaximumLikelihoodAmplitudeEstimationusable, azure-quantum would actually need to learn how to handle multi-circuit experiments, but with this PR we can at least makeAmplitudeEstimation,IterativeAmplitudeEstimation, andFasterAmplitudeEstimationusable, since they pass single-element circuit lists to therunmethod.EDIT: With this PR, every amplitude estimation method from Qiskit should start working.